benchmark: separate RegExp benchmark from v8 basic bench#482
Closed
yosuke-furukawa wants to merge 1 commit intonodejs:v1.xfrom
yosuke-furukawa:fix/bench
Closed
benchmark: separate RegExp benchmark from v8 basic bench#482yosuke-furukawa wants to merge 1 commit intonodejs:v1.xfrom yosuke-furukawa:fix/bench
yosuke-furukawa wants to merge 1 commit intonodejs:v1.xfrom
yosuke-furukawa:fix/bench
Conversation
Member
|
Thanks for bringing that up, @yosuke-furukawa. I suggested an alternative approach in #489 (and I'd like you to review it, if you don't mind) because I'd rather not touch files in the deps/ directory. |
Contributor
|
Closing in favor of #489 since @yosuke-furukawa LGTM'ed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegExp bench is separated from
run.js. And I createdrunRegExp.jsfor running another contexts.RegExp bench creates global
RegExp(https://github.com/iojs/io.js/blob/v1.x/deps/v8/benchmarks/regexp.js#L40).However, the
RegExpcauses a error. The detail is here.#475